content/browser/background_sync/background_sync_manager.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index a973793ea7c79f5ddc3e9391465e7475eda5958f..1ddae53b815d20bbe4d110bf788180bcbd521a86 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -748,6 +748,7 @@ void BackgroundSyncManager::DispatchSyncEvent(

if (active_version->running_status() != ServiceWorkerVersion::RUNNING) {

active_version->RunAfterStartWorker(

+ ServiceWorkerMetrics::EventType::SYNC,

base::Bind(&BackgroundSyncManager::DispatchSyncEvent,

weak_ptr_factory_.GetWeakPtr(), handle_id, active_version,

last_chance, callback),

« no previous file with comments | « no previous file | content/browser/geofencing/geofencing_manager.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')