Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 8744b98dd897645f9fc7ca170c18daf43f8bdb28..571c0c8e539776002be51923d48c2d43f2fdb1ca 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -253,7 +253,8 @@ class ServiceWorkerVersionTest : public testing::Test {
// Make sure worker is running.
scoped_refptr<MessageLoopRunner> runner(new MessageLoopRunner);
version_->RunAfterStartWorker(runner->QuitClosure(),
- CreateReceiverOnCurrentThread(&status));
+ CreateReceiverOnCurrentThread(&status),
+ event_type);
runner->Run();
EXPECT_EQ(SERVICE_WORKER_ERROR_MAX_VALUE, status);
EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
@@ -783,10 +784,12 @@ TEST_F(ServiceWorkerVersionTest, StaleUpdate_DoNotDeferTimer) {
// Stale time is not deferred.
version_->RunAfterStartWorker(
base::Bind(&base::DoNothing),
- base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+ base::Bind(&ServiceWorkerUtils::NoOpStatusCallback),
+ ServiceWorkerMetrics::EventType::UNKNOWN);
version_->RunAfterStartWorker(
base::Bind(&base::DoNothing),
- base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+ base::Bind(&ServiceWorkerUtils::NoOpStatusCallback),
+ ServiceWorkerMetrics::EventType::UNKNOWN);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(stale_time, version_->stale_time_);

Powered by Google App Engine
This is Rietveld 408576698