sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart - Issue 179583002: Revert "Emit named parameter information in declaration order."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

Issue 179583002: Revert "Emit named parameter information in declaration order." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart ('k') | sdk/lib/_internal/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

index b6eb5c8f01d4f75bfd10ff178efbff5114a987ca..c04a8989cdd55fd654831b0f8141b188923e75c6 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

@@ -46,7 +46,7 @@ class MetadataEmitter extends CodeEmitterHelper {

FunctionSignature signature = function.computeSignature(compiler);

if (signature.optionalParameterCount == 0) return const [];

List<int> defaultValues = <int>[];

- for (Element element in signature.optionalParameters) {

+ for (Element element in signature.orderedOptionalParameters) {

Constant value =

compiler.constantHandler.initialVariableValues[element];

String stringRepresentation = (value == null)