Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1795753005: Delete super old and unused git-cl-upload-hook. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : missing changes #

Patch Set 3 : argh, now should be ok #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M codereview.settings View 1 1 chunk +0 lines, -2 lines 0 comments Download
D git-cl-upload-hook View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tandrii(chromium)
4 years, 9 months ago (2016-03-14 15:54:54 UTC) #1
M-A Ruel
$ git grep git-cl-upload codereview.settings:GITCL_PREUPLOAD: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEAD codereview.settings:GITCL_PREDCOMMIT: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEAD man/html/git-cherry-pick-upload.html:<a href="git-cl-upload.html">git-cl-upload(1)</a></p></div> man/man1/git-cherry-pick-upload.1:\fBgit-cherry-pick\fR(1) \fBgit-cl-upload\fR(1) man/src/git-cherry-pick-upload.txt:linkgit:git-cl-upload[1] we need ...
4 years, 9 months ago (2016-03-14 17:38:18 UTC) #2
tandrii(chromium)
On 2016/03/14 17:38:18, M-A Ruel wrote: > $ git grep git-cl-upload > codereview.settings:GITCL_PREUPLOAD: > http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEAD ...
4 years, 9 months ago (2016-03-14 18:40:16 UTC) #3
M-A Ruel
git-cherry-pick-upload still exists. (I never used it)
4 years, 9 months ago (2016-03-14 19:09:40 UTC) #4
tandrii(chromium)
On 2016/03/14 19:09:40, M-A Ruel wrote: > git-cherry-pick-upload still exists. (I never used it) thanks ...
4 years, 9 months ago (2016-03-14 19:44:46 UTC) #5
M-A Ruel
On 2016/03/14 19:44:46, tandrii(chromium) wrote: > On 2016/03/14 19:09:40, M-A Ruel wrote: > > git-cherry-pick-upload ...
4 years, 9 months ago (2016-03-14 20:39:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1795753005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1795753005/40001
4 years, 9 months ago (2016-03-14 22:10:24 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 22:13:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299283

Powered by Google App Engine
This is Rietveld 408576698