Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179553008: Simplify volume manager in Files app. (Closed)

Created:
6 years, 10 months ago by mtomasz
Modified:
6 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Simplify volume manager in Files app. This patch cleans up and removed redundant code by making use of the assumption that file systems are different per volume TEST=Tested manually + partly browser tests. BUG=338582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253781

Patch Set 1 #

Patch Set 2 : Updated tests. #

Patch Set 3 : Rebased. #

Total comments: 2

Patch Set 4 : Fixed. #

Patch Set 5 : Fixed unmounting. #

Messages

Total messages: 12 (0 generated)
mtomasz
@hirono: PTAL. This change depends on 180793006. Thanks.
6 years, 10 months ago (2014-02-26 04:37:39 UTC) #1
hirono
On 2014/02/26 04:37:39, mtomasz wrote: > @hirono: PTAL. This change depends on 180793006. Thanks. Please ...
6 years, 10 months ago (2014-02-26 04:58:06 UTC) #2
hirono
https://codereview.chromium.org/179553008/diff/30001/chrome/browser/resources/file_manager/background/js/volume_manager.js File chrome/browser/resources/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/179553008/diff/30001/chrome/browser/resources/file_manager/background/js/volume_manager.js#newcode214 chrome/browser/resources/file_manager/background/js/volume_manager.js:214: null, // Root entry is not found. nit: File ...
6 years, 10 months ago (2014-02-26 06:33:02 UTC) #3
mtomasz
https://codereview.chromium.org/179553008/diff/30001/chrome/browser/resources/file_manager/background/js/volume_manager.js File chrome/browser/resources/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/179553008/diff/30001/chrome/browser/resources/file_manager/background/js/volume_manager.js#newcode214 chrome/browser/resources/file_manager/background/js/volume_manager.js:214: null, // Root entry is not found. On 2014/02/26 ...
6 years, 10 months ago (2014-02-26 07:00:38 UTC) #4
hirono
lgtm!
6 years, 10 months ago (2014-02-26 07:28:52 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-27 00:27:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/179553008/70001
6 years, 10 months ago (2014-02-27 00:30:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-27 02:57:45 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=271031
6 years, 10 months ago (2014-02-27 02:57:45 UTC) #9
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-27 02:57:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/179553008/70001
6 years, 10 months ago (2014-02-27 03:06:58 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 13:31:36 UTC) #12
Message was sent while issue was closed. 
Change committed as 253781

Powered by Google App Engine
This is Rietveld 408576698