Issue 179553002: Don't eliminate loads with incompatible representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179553002: Don't eliminate loads with incompatible representations. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Hannes Payer (out of office), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Don't eliminate loads with incompatible types or representations. BUG=346343 LOG=y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19536

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	src/hydrogen-load-elimination.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-346343.js	View	1	1 chunk	+11 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Hey Toon, Here's the fix for the load elimination bug. PTAL

6 years, 10 months ago (2014-02-25 09:20:01 UTC) #1

Toon Verwaest

lgtm if you rewrite the test without OSR but just %OptimizeFunctionOnNextCall

6 years, 10 months ago (2014-02-25 09:25:29 UTC) #2

Benedikt Meurer

On 2014/02/25 09:25:29, Toon Verwaest wrote: > lgtm if you rewrite the test without OSR ...

6 years, 10 months ago (2014-02-25 09:33:37 UTC) #3

Benedikt Meurer

6 years, 10 months ago (2014-02-25 09:55:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19536 (tree was closed).