Chromium Code Reviews

Issue 179553002: Don't eliminate loads with incompatible representations. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Hannes Payer (out of office), Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Don't eliminate loads with incompatible types or representations. BUG=346343 LOG=y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19536

Patch Set 1 #

Patch Set 2 : Also take into account the instruction's type. #

Unified diffs Side-by-side diffs Stats (+14 lines, -11 lines)
M src/hydrogen-load-elimination.cc View 1 chunk +3 lines, -1 line 0 comments
A + test/mjsunit/regress/regress-346343.js View 1 chunk +11 lines, -10 lines 0 comments

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Hey Toon, Here's the fix for the load elimination bug. PTAL
6 years, 10 months ago (2014-02-25 09:20:01 UTC) #1
Toon Verwaest
lgtm if you rewrite the test without OSR but just %OptimizeFunctionOnNextCall
6 years, 10 months ago (2014-02-25 09:25:29 UTC) #2
Benedikt Meurer
On 2014/02/25 09:25:29, Toon Verwaest wrote: > lgtm if you rewrite the test without OSR ...
6 years, 10 months ago (2014-02-25 09:33:37 UTC) #3
Benedikt Meurer
6 years, 10 months ago (2014-02-25 09:55:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19536 (tree was closed).

Powered by Google App Engine