Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 17955002: Fix IndexedDB after r208777. (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -81 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.h View 5 chunks +11 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 8 chunks +10 lines, -18 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl.h View 3 chunks +6 lines, -1 line 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl_unittest.cc View 1 3 chunks +15 lines, -4 lines 0 comments Download
M content/child/indexed_db/proxy_webidbdatabase_impl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/child/indexed_db/proxy_webidbdatabase_impl.cc View 17 chunks +24 lines, -21 lines 0 comments Download
M content/child/indexed_db/proxy_webidbfactory_impl.h View 3 chunks +6 lines, -1 line 0 comments Download
M content/child/indexed_db/proxy_webidbfactory_impl.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M content/child/thread_safe_sender.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/worker_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
7 years, 5 months ago (2013-06-26 22:31:10 UTC) #1
jsbell
change lgtm but looks like indexed_db_dispatcher_unittest.cc will need to be updated as well
7 years, 5 months ago (2013-06-26 22:38:22 UTC) #2
jam
On 2013/06/26 22:38:22, jsbell wrote: > change lgtm but looks like indexed_db_dispatcher_unittest.cc will need to ...
7 years, 5 months ago (2013-06-26 22:48:00 UTC) #3
jsbell
7 years, 5 months ago (2013-06-26 22:50:57 UTC) #4
On 2013/06/26 22:48:00, jam wrote:
> On 2013/06/26 22:38:22, jsbell wrote:
> > change lgtm but looks like indexed_db_dispatcher_unittest.cc  will need to
be
> > updated as well
> 
> just updated it to fix unittests. btw I ran
> "webkit\tools\layout_tests\run_webkit_tests.bat  --debug storage/indexeddb"
and
> they passed, is there any other tests I need to test?

Those were the only failures I saw, running all of the IDB unit/browser/layout
tests

Make sure your loal copy of LayoutTests/TestExpectations doesn't still have the
Skip lines in or it may have skipped those tests!

Powered by Google App Engine
This is Rietveld 408576698