Issue 1795233002: Improve error messages containing named function types and clean up some duplicated code (issue 259…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1795233002: Improve error messages containing named function types and clean up some duplicated code (issue 259… (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson

Modified:
4 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve error messages containing named function types and clean up some duplicated code (issue 25988) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8c9cbdcae1197256c1655aa7e9233c0aa4b0ea5b

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -89 lines)			Patch
	M	pkg/analyzer/lib/src/dart/element/type.dart	View		2 chunks	+22 lines, -83 lines	0 comments	Download
	M	pkg/analyzer/lib/src/generated/error.dart	View		6 chunks	+19 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

4 years, 9 months ago (2016-03-13 18:38:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c9cbdcae1197256c1655aa7e9233c0aa4b0ea5b (presubmit successful).