Issue 1795123005: Correctly mark generic failures as RuntimeError for Dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1795123005: Correctly mark generic failures as RuntimeError for Dartium (Closed)

Created:
4 years, 9 months ago by terry

Modified:
4 years, 9 months ago

Reviewers:
Leaf, Alan Knight

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Correctly mark generic failures as RuntimeError for Dartium TBR=alanknight@google.com,leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/c59f43a42d82f845ed5d715183451a12f5fbe7f7

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

Committed patchset #1 (id:1) manually as c59f43a42d82f845ed5d715183451a12f5fbe7f7 (presubmit successful).

4 years, 9 months ago (2016-03-14 01:52:04 UTC) #2

Leaf

4 years, 9 months ago (2016-03-14 18:25:40 UTC) #3

Message was sent while issue was closed.

lgtm

Apparently dartium currently reports compile time errors (which is what these
are, and were marked as) as runtime errors:

https://github.com/dart-lang/sdk/issues/22072

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages