Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1794943007: On stack overflow, just perform a regular GC instead of an OOM emergency GC. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

On stack overflow, just perform a regular GC instead of an OOM emergency GC. The OOM emergency GCs result in time outs on the stress GC bots. Doing a regular stress compaction GC is enough to stress the garbage collector. BUG= Committed: https://crrev.com/380676e2dadf94062f3783ebbd49db7387b893fc Cr-Commit-Position: refs/heads/master@{#34740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-14 12:54:17 UTC) #3
ulan
lgtm
4 years, 9 months ago (2016-03-14 12:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1794943007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1794943007/1
4 years, 9 months ago (2016-03-14 12:59:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 13:19:03 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 13:19:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380676e2dadf94062f3783ebbd49db7387b893fc
Cr-Commit-Position: refs/heads/master@{#34740}

Powered by Google App Engine
This is Rietveld 408576698