Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| index b3fa9b1c325272dcb451a73a4917a98efd5d0aaa..073de7d2286c2eda8cd5a383ae681443edb5f024 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| @@ -278,5 +278,34 @@ WebInspector.RequestTimingView.createTimingTable = function(request, navigationS |
| note.appendChild(WebInspector.linkifyDocumentationURLAsNode("profile/network-performance/resource-loading#view-network-timing-details-for-a-specific-resource", WebInspector.UIString("Explanation"))); |
| footer.createChild("td").createTextChild(Number.secondsToString(totalDuration, true)); |
| + var serverTimings = request.serverTimings; |
| + if (!serverTimings) |
| + return tableElement; |
| + |
| + var breakEl = tableElement.createChild("tr", "network-timing-table-header").createChild("td"); |
| + breakEl.colSpan = 3; |
| + breakEl.createChild("hr", "break"); |
| + var serverHeader = tableElement.createChild("tr", "network-timing-table-header"); |
| + serverHeader.createChild("td").createTextChild(WebInspector.UIString("Server-Timing")); |
|
paulirish
2016/03/20 20:16:27
"Server Timing"
|
| + serverHeader.createChild("td").createTextChild(""); |
| + serverHeader.createChild("td").createTextChild(WebInspector.UIString("TIME")); |
| + |
| + /** |
| + * @param {!WebInspector.ServerTiming} serverTiming |
| + */ |
| + function addTiming(serverTiming) |
| + { |
| + var tr = tableElement.createChild("tr", serverTiming.metric == "total" ? "network-timing-footer" : ""); |
| + var metric = tr.createChild("td", "network-timing-metric"); |
| + metric.colSpan = 2; |
| + metric.createTextChild(serverTiming.description || serverTiming.metric); |
|
paulirish
2016/03/20 20:16:27
Would you want to see both metric name and optiona
sroussey
2016/04/22 00:55:08
I don't think so. A lot of people will have a metr
|
| + |
| + var label = tr.createChild("td").createChild("div", "network-timing-bar-title"); |
| + label.textContent = Number.secondsToString(serverTiming.value, true); |
| + } |
| + |
| + serverTimings.filter(item => item.metric.toLowerCase() != "total").forEach(addTiming); |
| + serverTimings.filter(item => item.metric.toLowerCase() == "total").forEach(addTiming); |
|
paulirish
2016/03/20 20:16:27
This does rely on convention that a metric with th
|
| + |
| return tableElement; |
| } |