Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Issue 1794783006: Add Server-Timing support to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated version Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
index b3fa9b1c325272dcb451a73a4917a98efd5d0aaa..133099bf110cc899c1cc1e5664a45336ae809daa 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
@@ -278,5 +278,34 @@ WebInspector.RequestTimingView.createTimingTable = function(request, navigationS
note.appendChild(WebInspector.linkifyDocumentationURLAsNode("profile/network-performance/resource-loading#view-network-timing-details-for-a-specific-resource", WebInspector.UIString("Explanation")));
footer.createChild("td").createTextChild(Number.secondsToString(totalDuration, true));
+ var serverHeader;
+ var serverTimings = request.serverTimings;
+
+ if (serverTimings) {
pfeldman 2016/03/15 20:18:59 [style] Blink's code style suggests to prefer earl
+ var breakEl = tableElement.createChild("tr", "network-timing-table-header").createChild("td");
+ breakEl.colSpan = 3;
+ breakEl.createChild("hr", "break");
+ serverHeader = tableElement.createChild("tr", "network-timing-table-header");
+ serverHeader.createChild("td").createTextChild(WebInspector.UIString("Server-Timing"));
+ serverHeader.createChild("td").createTextChild("");
+ serverHeader.createChild("td").createTextChild(WebInspector.UIString("TIME"));
+
+ /**
+ * @param {!WebInspector.ServerTiming} serverTiming
+ */
+ function addTiming(serverTiming) {
pfeldman 2016/03/15 20:18:59 [style] { goes next line.
+ var tr = tableElement.createChild("tr", serverTiming.metric == "total" ? "network-timing-footer" : "");
+ var metric = tr.createChild("td", "network-timing-metric");
+ metric.colSpan = 2;
+ metric.createTextChild(serverTiming.description || serverTiming.metric);
+
+ var label = tr.createChild("td").createChild("div", "network-timing-bar-title");
+ label.textContent = Number.secondsToString(serverTiming.value, true);
+ }
+
+ serverTimings.filter(item => item.metric.toLowerCase() != "total").forEach(addTiming);
+ serverTimings.filter(item => item.metric.toLowerCase() == "total").forEach(addTiming);
+ }
+
return tableElement;
}

Powered by Google App Engine
This is Rietveld 408576698