Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| index c074f32939bb4f7e4369d31a953e49b8c5817b48..a46906b9756039ddd991b95cac18ada1c4a0f9f1 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js |
| @@ -278,5 +278,50 @@ WebInspector.RequestTimingView.createTimingTable = function(request, navigationS |
| note.appendChild(WebInspector.linkifyDocumentationURLAsNode("profile/network-performance/resource-loading#view-network-timing-details-for-a-specific-resource", WebInspector.UIString("Explanation"))); |
| footer.createChild("td").createTextChild(Number.secondsToString(totalDuration, true)); |
| + var serverTimings = request.serverTimings; |
| + if (!serverTimings) |
| + return tableElement; |
| + |
| + var breakEl = tableElement.createChild("tr", "network-timing-table-header").createChild("td"); |
|
caseq
2016/04/26 03:56:42
nit: breakElement, blink's code style doesn't favo
|
| + breakEl.colSpan = 3; |
| + breakEl.createChild("hr", "break"); |
| + var serverHeader = tableElement.createChild("tr", "network-timing-table-header"); |
| + serverHeader.createChild("td").createTextChild(WebInspector.UIString("Server Timing")); |
| + serverHeader.createChild("td"); |
| + serverHeader.createChild("td").createTextChild(WebInspector.UIString("TIME")); |
| + |
| + var colorGenerator = new WebInspector.FlameChart.ColorGenerator( |
| + { min: 0, max: 360, count:36 }, |
| + { min: 50, max: 80 }, |
| + 80 |
| + ); |
| + |
| + /** |
| + * @param {!WebInspector.ServerTiming} serverTiming |
| + */ |
| + function addTiming(serverTiming) |
| + { |
| + var isTotal = serverTiming.metric.toLowerCase() === "total"; |
| + var tr = tableElement.createChild("tr", isTotal ? "network-timing-footer" : ""); |
| + var metric = tr.createChild("td", "network-timing-metric"); |
| + metric.createTextChild(serverTiming.description || serverTiming.metric); |
| + var row = tr.createChild("td").createChild("div", "network-timing-row"); |
| + var left = scale * (endTime - startTime - serverTiming.value); |
| + if (serverTiming.value && left >= 0) { // don't chart values too big or too small |
| + var bar = row.createChild("span", "network-timing-bar server-timing"); |
| + bar.style.left = left + "%"; |
| + bar.style.right = right + "%"; |
|
caseq
2016/04/26 03:56:42
let's avoid using right from the closure, especial
|
| + bar.textContent = "\u200B"; // Important for 0-time items to have 0 width. |
| + if (!isTotal) |
| + bar.style.backgroundColor = colorGenerator.colorForID(serverTiming.metric); |
| + } |
| + var label = tr.createChild("td").createChild("div", "network-timing-bar-title"); |
| + if (typeof serverTiming.value === "number") // a metric timing value is optional |
| + label.textContent = Number.secondsToString(serverTiming.value, true); |
| + } |
| + |
| + serverTimings.filter(item => item.metric.toLowerCase() !== "total").forEach(addTiming); |
| + serverTimings.filter(item => item.metric.toLowerCase() === "total").forEach(addTiming); |
| + |
| return tableElement; |
| } |