Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Issue 1794783006: Add Server-Timing support to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
index b3fa9b1c325272dcb451a73a4917a98efd5d0aaa..19bc301112dba51858dfaabc270af3920f66aaf5 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js
@@ -265,7 +265,7 @@ WebInspector.RequestTimingView.createTimingTable = function(request, navigationS
var label = tr.createChild("td").createChild("div", "network-timing-bar-title");
label.textContent = Number.secondsToString(duration, true);
}
-
+
if (!request.finished) {
var cell = tableElement.createChild("tr").createChild("td", "caution");
cell.colSpan = 3;
@@ -278,5 +278,28 @@ WebInspector.RequestTimingView.createTimingTable = function(request, navigationS
note.appendChild(WebInspector.linkifyDocumentationURLAsNode("profile/network-performance/resource-loading#view-network-timing-details-for-a-specific-resource", WebInspector.UIString("Explanation")));
footer.createChild("td").createTextChild(Number.secondsToString(totalDuration, true));
+ var serverHeader;
+ var serverTimings = request.serverTimings;
+
+ if (serverTimings) {
+ tableElement.createChild("tr").createChild("td").createTextChild("\u00a0");
+ serverHeader = tableElement.createChild("tr", "network-timing-table-header");
+ serverHeader.createChild("td").createTextChild("Server-Timing");
pfeldman 2016/03/14 22:54:34 User-visible strings should be wrapped with WebIns
sroussey 2016/04/22 00:55:07 OK! You might look at other things in this file --
+ serverHeader.createChild("td").createTextChild("");
+ serverHeader.createChild("td").createTextChild("TIME");
pfeldman 2016/03/14 22:54:34 ditto
+
+ var addTiming = (serverTiming) => {
pfeldman 2016/03/14 22:54:34 Please declare as a named function. /** * @param
+ var tr = tableElement.createChild("tr", serverTiming.metric == "total" ? "network-timing-footer" : "");
+ var metric = tr.createChild("td");
+ metric.colSpan = 2;
+ metric.createTextChild(WebInspector.RequestTimingView._timeRangeTitle(serverTiming.description || serverTiming.metric));
+
+ var label = tr.createChild("td").createChild("div", "network-timing-bar-title");
+ label.textContent = Number.secondsToString(serverTiming.value, true);
+ };
+ serverTimings.filter(item => item.metric.toLowerCase() != "total").forEach(addTiming);
+ serverTimings.filter(item => item.metric.toLowerCase() == "total").forEach(addTiming);
+ }
+
return tableElement;
}

Powered by Google App Engine
This is Rietveld 408576698