Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1794573002: Add an `mb audit` command to track the GYP->GN progress. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
Reviewers:
estaab
CC:
chromium-reviews, sshruthi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an `mb audit` command to track the GYP->GN progress. This adds a command by which we can track - which builders no longer exist but are in the config file and should be purged - which builders aren't in the config file, meaning we haven't looked at them - which builders still need to have their flags checked. - which builders are still on GYP R=estaab@chromium.org BUG=432967, 481692 Committed: https://crrev.com/867bcf4ae6b7e8e64b72cfa4cef2ab7cdd2239cf Cr-Commit-Position: refs/heads/master@{#381094}

Patch Set 1 : initial patch for review #

Total comments: 1

Patch Set 2 : update w/ review feedback, clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M tools/mb/docs/user_guide.md View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/mb/mb.py View 1 4 chunks +133 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
estaab
lgtm https://codereview.chromium.org/1794573002/diff/20001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/1794573002/diff/20001/tools/mb/mb.py#newcode430 tools/mb/mb.py:430: for builder in buildbot_builders: nit: missing_in_config = sorted(set(buildbot_builders) ...
4 years, 9 months ago (2016-03-12 04:07:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1794573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1794573002/40001
4 years, 9 months ago (2016-03-14 20:45:20 UTC) #6
Dirk Pranke
On 2016/03/12 04:07:27, estaab wrote: > you could probably just operate on sets starting at ...
4 years, 9 months ago (2016-03-14 20:46:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-14 22:28:40 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 22:30:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/867bcf4ae6b7e8e64b72cfa4cef2ab7cdd2239cf
Cr-Commit-Position: refs/heads/master@{#381094}

Powered by Google App Engine
This is Rietveld 408576698