Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1794563002: Fix broken build: SimpleTypes_InT32 -> SimpleTypes_Int32 (Closed)

Created:
4 years, 9 months ago by vardhan
Modified:
4 years, 9 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix broken build: SimpleTypes_InT32 -> SimpleTypes_Int32 BUG=#708 R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f4766bdb63b5c079af7cc791ce4cd4b9a171dc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojom/mojom_parser/serialization/serialization_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vardhan
ptal
4 years, 9 months ago (2016-03-12 01:56:21 UTC) #1
rudominer
lgtm
4 years, 9 months ago (2016-03-12 01:56:48 UTC) #2
vardhan
4 years, 9 months ago (2016-03-12 02:08:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f4766bdb63b5c079af7cc791ce4cd4b9a171dc3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698