content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1794513003: Don't rely on the pending NavigationEntry for location.replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1794513003: Don't rely on the pending NavigationEntry for location.replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test for 593153 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl.cc ('K') | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 05694a8249c3f0c2ecc54994cf615ad04bab70cd..6f29a8610ed2cae48618c583054a7749ec5951b3 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -1509,7 +1509,7 @@ TEST_F(NavigationControllerTest, ResetEntryValuesAfterCommit) {

// Fake a commit response.

main_test_rfh()->PrepareForCommit();

- main_test_rfh()->SendNavigate(1, entry_id, true, url1);

+ main_test_rfh()->SendNavigateWithReplacement(1, entry_id, true, url1);

// Certain values that are only used for pending entries get reset after

// commit.

@@ -3397,7 +3397,7 @@ TEST_F(NavigationControllerTest, RendererInitiatedPendingEntries) {

navigator->DidStartProvisionalLoad(main_test_rfh(), url2,

base::TimeTicks::Now());

EXPECT_TRUE(controller.GetPendingEntry()->should_replace_entry());

- main_test_rfh()->SendNavigate(0, 0, false, url2);

+ main_test_rfh()->SendNavigateWithReplacement(0, 0, false, url2);

EXPECT_EQ(url2, controller.GetLastCommittedEntry()->GetURL());

}