Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1794513003: Don't rely on the pending NavigationEntry for location.replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test for 593153 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index deb6db483e4f6f200801220237bbe60dc0f322f3..ae9bf68a53f7f1d07e05c10da54db07407b820d7 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -372,8 +372,7 @@ class CONTENT_EXPORT NavigationControllerImpl
NavigationEntryImpl* pending_entry_;
// If a new entry fails loading, details about it are temporarily held here
- // until the error page is shown. These variables are only valid if
- // |failed_pending_entry_id_| is not 0.
+ // until the error page is shown (or 0 otherwise).
//
// TODO(avi): We need a better way to handle the connection between failed
// loads and the subsequent load of the error page. This current approach has
@@ -381,7 +380,6 @@ class CONTENT_EXPORT NavigationControllerImpl
// error page loaded, and 2. This doesn't work very well for frames.
// http://crbug.com/474261
int failed_pending_entry_id_;
- bool failed_pending_entry_should_replace_;
// The index of the currently visible entry.
int last_committed_entry_index_;

Powered by Google App Engine
This is Rietveld 408576698