Fix sending multiple feedback reports within short durations of each other

chrome/browser/extensions/api/feedback_private/feedback_service.h

Index: chrome/browser/extensions/api/feedback_private/feedback_service.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.h b/chrome/browser/extensions/api/feedback_private/feedback_service.h
index 9588c534d61988e998a1891e2c48cd892218f9d0..f07d868f35ec9897e32678ddcc1a144829546d27 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_service.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.h
@@ -7,7 +7,9 @@
 
 #include <stdint.h>
 
+#include <map>

[xiyuan, 2016/03/16 16:39:28]

nit: no longer in use.

[afakhry, 2016/03/16 17:51:22]

Done.

 #include <vector>
+
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
@@ -30,9 +32,9 @@ typedef std::vector<linked_ptr<SystemInformation> > SystemInformationList;
 // the pieces are available.
 class FeedbackService : public base::SupportsWeakPtr<FeedbackService> {
  public:
-  typedef base::Callback<void(bool)> SendFeedbackCallback;
-  typedef base::Callback<void(const SystemInformationList& sys_info)>
-      GetSystemInformationCallback;
+  using SendFeedbackCallback = base::Callback<void(bool)>;
+  using GetSystemInformationCallback =
+      base::Callback<void(const SystemInformationList&)>;
 
   FeedbackService();
   virtual ~FeedbackService();
@@ -48,22 +50,23 @@ class FeedbackService : public base::SupportsWeakPtr<FeedbackService> {
 
  private:
   // Callbacks to receive blob data.
-  void AttachedFileCallback(scoped_ptr<std::string> data,
+  void AttachedFileCallback(scoped_refptr<feedback::FeedbackData> feedback_data,
+                            const SendFeedbackCallback& callback,
+                            scoped_ptr<std::string> data,
                             int64_t total_blob_length);
-  void ScreenshotCallback(scoped_ptr<std::string> data,
+  void ScreenshotCallback(scoped_refptr<feedback::FeedbackData> feedback_data,
+                          const SendFeedbackCallback& callback,
+                          scoped_ptr<std::string> data,
                           int64_t total_blob_length);
 
-  // Checks if we have read all the blobs we need to; signals the feedback
-  // data object once all the requisite data has been populated.
-  void CompleteSendFeedback();
-
   void OnSystemLogsFetchComplete(
+      const GetSystemInformationCallback& callback,
       scoped_ptr<system_logs::SystemLogsResponse> sys_info);
 
-  GetSystemInformationCallback system_information_callback_;
-  SendFeedbackCallback send_feedback_callback_;
-
-  scoped_refptr<feedback::FeedbackData> feedback_data_;
+  // Checks if we have read all the blobs we need to; signals the feedback
+  // data object once all the requisite data has been populated.
+  void CompleteSendFeedback(scoped_refptr<feedback::FeedbackData> feedback_data,
+                            const SendFeedbackCallback& callback);
 
   DISALLOW_COPY_AND_ASSIGN(FeedbackService);
 };