Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/search/search_unittest.cc

Issue 17945002: Make --force-fieldtrials not activate them in the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/extensions/api/metrics_private/metrics_apitest.cc ('k') | content/renderer/renderer_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/search_unittest.cc
===================================================================
--- chrome/browser/search/search_unittest.cc (revision 209140)
+++ chrome/browser/search/search_unittest.cc (working copy)
@@ -150,8 +150,8 @@
}
TEST_F(InstantExtendedAPIEnabledTest, EnabledViaFinchFlag) {
- ASSERT_TRUE(base::FieldTrialList::CreateTrialsFromString(
- "InstantExtended/Group1 espv:42/"));
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
+ "Group1 espv:42"));
EXPECT_TRUE(IsInstantExtendedAPIEnabled());
EXPECT_EQ(42ul, EmbeddedSearchPageVersion());
ValidateMetrics(INSTANT_EXTENDED_NOT_SET);
@@ -159,8 +159,8 @@
TEST_F(InstantExtendedAPIEnabledTest, DisabledViaCommandLineFlag) {
GetCommandLine()->AppendSwitch(switches::kDisableInstantExtendedAPI);
- ASSERT_TRUE(base::FieldTrialList::CreateTrialsFromString(
- "InstantExtended/Group1 espv:2/"));
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
+ "Group1 espv:2"));
EXPECT_FALSE(IsInstantExtendedAPIEnabled());
EXPECT_EQ(0ul, EmbeddedSearchPageVersion());
ValidateMetrics(INSTANT_EXTENDED_OPT_OUT);
@@ -450,8 +450,8 @@
EnableInstantExtendedAPIForTesting();
// Enable Instant.
- ASSERT_TRUE(base::FieldTrialList::CreateTrialsFromString(
- "InstantExtended/Group1 allow_instant:1/"));
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
+ "Group1 allow_instant:1"));
ASSERT_TRUE(IsInstantCheckboxVisible());
// Enable suggest.
« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/extensions/api/metrics_private/metrics_apitest.cc ('k') | content/renderer/renderer_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698