Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: base/metrics/field_trial.cc

Issue 17945002: Make --force-fieldtrials not activate them in the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/field_trial.cc
===================================================================
--- base/metrics/field_trial.cc (revision 208942)
+++ base/metrics/field_trial.cc (working copy)
@@ -366,7 +366,8 @@
}
// static
-bool FieldTrialList::CreateTrialsFromString(const std::string& trials_string) {
+bool FieldTrialList::CreateTrialsFromString(const std::string& trials_string,
+ bool activate_trials) {
DCHECK(global_);
if (trials_string.empty() || !global_)
return true;
@@ -391,7 +392,8 @@
// Call |group()| to mark the trial as "used" and notify observers, if any.
// This is needed to ensure the trial is properly reported in child process
// crash reports.
Ilya Sherman 2013/06/28 00:58:07 nit: Please move this comment inside the if-stmt,
Alexei Svitkine (slow) 2013/06/28 17:05:15 Done.
- trial->group();
+ if (activate_trials)
+ trial->group();
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698