Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1794433002: Use ClientAuthenticationConfig in PairingClientAuthenticator (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ClientAuthenticationConfig in PairingClientAuthenticator Moved ClientAuthenticationConfig to a separate file and now it's used in PairingClientAuthenticator. BUG=593123 Committed: https://crrev.com/64adc27d798830194401562945398dd396e652db Cr-Commit-Position: refs/heads/master@{#380872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -84 lines) Patch
M remoting/client/chromoting_client.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/chromoting_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/authenticator.h View 2 chunks +1 line, -27 lines 0 comments Download
A remoting/protocol/client_authentication_config.h View 1 chunk +62 lines, -0 lines 0 comments Download
A + remoting/protocol/client_authentication_config.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.h View 1 chunk +1 line, -18 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.cc View 2 chunks +1 line, -6 lines 0 comments Download
M remoting/protocol/pairing_client_authenticator.h View 3 chunks +8 lines, -11 lines 0 comments Download
M remoting/protocol/pairing_client_authenticator.cc View 4 chunks +9 lines, -14 lines 0 comments Download
M remoting/protocol/rejecting_authenticator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/spake2_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/third_party_client_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/v2_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-11 19:42:41 UTC) #3
Jamie
lgtm
4 years, 9 months ago (2016-03-11 22:47:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1794433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1794433002/20001
4 years, 9 months ago (2016-03-12 08:17:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-12 09:12:51 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 09:14:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64adc27d798830194401562945398dd396e652db
Cr-Commit-Position: refs/heads/master@{#380872}

Powered by Google App Engine
This is Rietveld 408576698