Issue 179443003: SSE2 implementation of S32A_D565_Opaque_Dither

Issue 179443003: SSE2 implementation of S32A_D565_Opaque_Dither (Closed)

Created:
6 years, 10 months ago by qiankun

Modified:
6 years, 9 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

SSE2 implementation of S32A_D565_Opaque_Dither Run benchmarks with command line option "--forceDither true --forceBlend 1", almost all the benchmarks exercised S32A_D565_Opaque_Dither can get about 20%-70% performance improvement. Here are the data on i7-3770: before after verts 4314.81 3627.64 15.93% constXTile_MM_filter_trans 1434.22 432.82 69.82% constXTile_CC_filter_trans_scale 1440.17 437.00 69.66% constXTile_RR_filter_trans 1436.96 431.93 69.94% constXTile_MM_trans_scale 1436.33 435.77 69.66% constXTile_CC_trans 1433.12 431.36 69.90% constXTile_RR_trans_scale 1436.13 436.06 69.64% constXTile_MM_filter 1411.55 408.06 71.09% constXTile_CC_filter_scale 1416.68 414.18 70.76% constXTile_RR_filter 1429.46 409.81 71.33% constXTile_MM_scale 1415.00 412.56 70.84% constXTile_CC 1410.32 408.36 71.04% constXTile_RR_scale 1413.26 413.16 70.77% repeatTile_4444_A 1922.01 879.03 54.27% repeatTile_4444_A 1430.68 818.34 42.80% repeatTile_4444_X 1817.43 816.63 55.07% maskshader 5911.09 5895.46 0.26% gradient_create_alpha 4.41 4.41 -0.15% gradient_conical_clamp_3color 35298.71 27574.34 21.88% gradient_conical_clamp_hicolor 35262.15 27538.99 21.90% gradient_conical_clamp 35276.21 27599.80 21.76% gradient_radial2_mirror 20846.74 12969.39 37.79% gradient_radial2_clamp_hicolor 21848.12 13967.57 36.07% gradient_radial2_clamp 21829.95 13978.57 35.97% bitmap_4444_A_scale_rotate_bicubic 105.31 87.13 17.26% bitmap_4444_A_scale_bicubic 73.69 47.76 35.20% bitmap_4444_update_scale_rotate_bilerp 125.65 87.86 30.08% bitmap_4444_update_volatile_scale_rotate_bilerp 125.50 87.65 30.16% bitmap_4444_scale_rotate_bilerp 124.46 87.91 29.37% bitmap_4444_A_scale_rotate_bilerp 105.09 87.27 16.96% bitmap_4444_update_scale_bilerp 106.78 63.28 40.74% bitmap_4444_update_volatile_scale_bilerp 106.66 63.66 40.32% bitmap_4444_scale_bilerp 106.70 63.19 40.78% bitmap_4444_A_scale_bilerp 83.05 62.25 25.04% bitmap_a8 98.11 52.76 46.22% bitmap_a8_A 98.24 52.85 46.20% BUG= Committed: http://code.google.com/p/skia/source/detail?r=13699

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and fix comments #

Patch Set 3 : fix style #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -1 line)			Patch
M	src/opts/SkBlitRow_opts_SSE2.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/opts/SkBlitRow_opts_SSE2.cpp	View	1 2	1 chunk	+196 lines, -0 lines	0 comments	Download
M	src/opts/opts_check_SSE2.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm Please tack a 2 onto the name before submitting. https://codereview.chromium.org/179443003/diff/1/src/opts/SkBlitRow_opts_SSE2.h File src/opts/SkBlitRow_opts_SSE2.h (right): https://codereview.chromium.org/179443003/diff/1/src/opts/SkBlitRow_opts_SSE2.h#newcode38 ...

6 years, 9 months ago (2014-03-06 17:31:02 UTC) #4

qiankun

Thanks for your review:) https://codereview.chromium.org/179443003/diff/1/src/opts/SkBlitRow_opts_SSE2.h File src/opts/SkBlitRow_opts_SSE2.h (right): https://codereview.chromium.org/179443003/diff/1/src/opts/SkBlitRow_opts_SSE2.h#newcode38 src/opts/SkBlitRow_opts_SSE2.h:38: void S32A_D565_Opaque_Dither_SSE(uint16_t* SK_RESTRICT dst, On ...

6 years, 9 months ago (2014-03-07 07:00:39 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/179443003/30001

6 years, 9 months ago (2014-03-07 07:02:42 UTC) #7

Message was sent while issue was closed.

Change committed as 13699

Expand Messages | Collapse Messages