chrome/browser/profiles/profile_impl.h - Issue 1794353003: Refactor ProfileInfoCache in c/b/profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl.h

Issue 1794353003: Refactor ProfileInfoCache in c/b/profiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bug that causes unit tests without debug code to fail. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_impl.h

diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h

index 1c7a2967c9bec0e1048a8f891a78b328ecf18672..515485afa602e46ff88327ac9ee3d81eb288a2f2 100644

--- a/chrome/browser/profiles/profile_impl.h

+++ b/chrome/browser/profiles/profile_impl.h

@@ -178,11 +178,11 @@ class ProfileImpl : public Profile {

void EnsureSessionServiceCreated();

#endif

- // Updates the ProfileInfoCache with data from this profile.

- void UpdateProfileSupervisedUserIdCache();

- void UpdateProfileNameCache();

- void UpdateProfileAvatarCache();

- void UpdateProfileIsEphemeralCache();

+ // Updates the ProfileAttributesStorage with the data from this profile.

+ void UpdateSupervisedUserIdInStorage();

+ void UpdateNameInStorage();

+ void UpdateAvatarInStorage();

+ void UpdateIsEphemeralInStorage();

void GetCacheParameters(bool is_media_context,

base::FilePath* cache_path,