Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1794333003: Clang update.py: clobber more CMake cache files (Closed)

Created:
4 years, 9 months ago by hans
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang update.py: clobber more CMake cache files The compiler info seems to get cached under CMakeFiles/3.2.2/CompilerId*. To clobber things properly, let's nuke any CmakeFiles dirs. BUG=594361 R=thakis@chromium.org TBR=thakis Committed: https://chromium.googlesource.com/chromium/src/+/16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d

Patch Set 1 #

Patch Set 2 : remove CMakeFiles recursively #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1794333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1794333003/20001
4 years, 9 months ago (2016-03-14 10:29:56 UTC) #4
Nico
lgtm
4 years, 9 months ago (2016-03-14 10:32:21 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d Cr-Commit-Position: refs/heads/master@{#380953}
4 years, 9 months ago (2016-03-14 10:48:44 UTC) #7
hans
4 years, 9 months ago (2016-03-14 10:49:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
16ae62ebdbef46d3cb638eb43ed9a0e6b2558e8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698