Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 179433004: Fix the bit massaging code in CompleteParserRecorder::WriteNumber. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix the bit massaging code in CompleteParserRecorder::WriteNumber. The original code, added by https://codereview.chromium.org/3384003/diff/7001/src/parser.cc 3.5 years ago, failed to write numbers which contain a chunk of 7 zeroes in the middle. The smallest such number is 2^14, so this is a problem if the source file to preparse contains 16384 or more symbols (which happens in the wild). This bug went unnoticed because the symbol data was not used by Parser (see https://codereview.chromium.org/172753002/ for starting to use it again) and there were no tests. R=ulan@chromium.org BUG=346221 LOG=y Committed: https://code.google.com/p/v8/source/detail?r=19538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M src/preparse-data.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/preparse-data.cc View 1 chunk +15 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, here's another entertaining CL for you, ptal.
6 years, 9 months ago (2014-02-25 11:00:14 UTC) #1
ulan
lgtm, nice!
6 years, 9 months ago (2014-02-25 11:28:57 UTC) #2
marja
6 years, 9 months ago (2014-02-25 11:51:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19538 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698