Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: components/user_manager/user_image/user_image.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_manager/user_image/user_image.cc
diff --git a/components/user_manager/user_image/user_image.cc b/components/user_manager/user_image/user_image.cc
index 10cd4482da504f2d3fae556b02ffe2d350fa0b7e..f8e87ec2ac3dd13231ee7080d69e018fa85437b7 100644
--- a/components/user_manager/user_image/user_image.cc
+++ b/components/user_manager/user_image/user_image.cc
@@ -37,17 +37,17 @@ scoped_ptr<UserImage::Bytes> UserImage::Encode(const SkBitmap& bitmap) {
}
// static
-UserImage UserImage::CreateAndEncode(const gfx::ImageSkia& image) {
+scoped_ptr<UserImage> UserImage::CreateAndEncode(const gfx::ImageSkia& image) {
if (image.isNull())
- return UserImage();
+ return make_scoped_ptr(new UserImage);
scoped_ptr<Bytes> image_bytes = Encode(*image.bitmap());
if (image_bytes) {
- UserImage result(image, *image_bytes);
- result.MarkAsSafe();
+ scoped_ptr<UserImage> result(new UserImage(image, *image_bytes));
hashimoto 2016/03/15 08:39:27 This line still copies image bytes.
satorux1 2016/03/16 02:01:30 Added a TODO comment.
+ result->MarkAsSafe();
return result;
}
- return UserImage(image);
+ return make_scoped_ptr(new UserImage(image));
}
UserImage::UserImage()

Powered by Google App Engine
This is Rietveld 408576698