Chromium Code Reviews| Index: components/user_manager/user_image/user_image.cc |
| diff --git a/components/user_manager/user_image/user_image.cc b/components/user_manager/user_image/user_image.cc |
| index 10cd4482da504f2d3fae556b02ffe2d350fa0b7e..f8e87ec2ac3dd13231ee7080d69e018fa85437b7 100644 |
| --- a/components/user_manager/user_image/user_image.cc |
| +++ b/components/user_manager/user_image/user_image.cc |
| @@ -37,17 +37,17 @@ scoped_ptr<UserImage::Bytes> UserImage::Encode(const SkBitmap& bitmap) { |
| } |
| // static |
| -UserImage UserImage::CreateAndEncode(const gfx::ImageSkia& image) { |
| +scoped_ptr<UserImage> UserImage::CreateAndEncode(const gfx::ImageSkia& image) { |
| if (image.isNull()) |
| - return UserImage(); |
| + return make_scoped_ptr(new UserImage); |
| scoped_ptr<Bytes> image_bytes = Encode(*image.bitmap()); |
| if (image_bytes) { |
| - UserImage result(image, *image_bytes); |
| - result.MarkAsSafe(); |
| + scoped_ptr<UserImage> result(new UserImage(image, *image_bytes)); |
|
hashimoto
2016/03/15 08:39:27
This line still copies image bytes.
satorux1
2016/03/16 02:01:30
Added a TODO comment.
|
| + result->MarkAsSafe(); |
| return result; |
| } |
| - return UserImage(image); |
| + return make_scoped_ptr(new UserImage(image)); |
| } |
| UserImage::UserImage() |