Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5668)

Unified Diff: chrome/browser/ui/webui/chromeos/image_source.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/image_source.cc
diff --git a/chrome/browser/ui/webui/chromeos/image_source.cc b/chrome/browser/ui/webui/chromeos/image_source.cc
index 3fb2775c7d483f887b540c11e9fb8be33619246a..6acf79b2d6c4d2c0ba991420d02b5dc3489ed69e 100644
--- a/chrome/browser/ui/webui/chromeos/image_source.cc
+++ b/chrome/browser/ui/webui/chromeos/image_source.cc
@@ -35,11 +35,11 @@ const char* kWhitelistedDirectories[] = {
// Callback for user_manager::UserImageLoader.
void ImageLoaded(
const content::URLDataSource::GotDataCallback& got_data_callback,
- const user_manager::UserImage& user_image) {
+ scoped_ptr<user_manager::UserImage> user_image) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (user_image.has_image_bytes())
- got_data_callback.Run(new base::RefCountedBytes(user_image.image_bytes()));
+ if (user_image->has_image_bytes())
+ got_data_callback.Run(new base::RefCountedBytes(user_image->image_bytes()));
hashimoto 2016/03/15 08:39:27 This line still copies image_bytes.
else
got_data_callback.Run(NULL);
}

Powered by Google App Engine
This is Rietveld 408576698