Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: components/user_manager/user_image/user_image.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/user_manager/user_image/user_image.h ('k') | components/wallpaper/wallpaper_manager_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_manager/user_image/user_image.cc
diff --git a/components/user_manager/user_image/user_image.cc b/components/user_manager/user_image/user_image.cc
index 10cd4482da504f2d3fae556b02ffe2d350fa0b7e..ce37ca2f64377700c959ffcafa616da4d151f70e 100644
--- a/components/user_manager/user_image/user_image.cc
+++ b/components/user_manager/user_image/user_image.cc
@@ -37,17 +37,18 @@ scoped_ptr<UserImage::Bytes> UserImage::Encode(const SkBitmap& bitmap) {
}
// static
-UserImage UserImage::CreateAndEncode(const gfx::ImageSkia& image) {
+scoped_ptr<UserImage> UserImage::CreateAndEncode(const gfx::ImageSkia& image) {
if (image.isNull())
- return UserImage();
+ return make_scoped_ptr(new UserImage);
scoped_ptr<Bytes> image_bytes = Encode(*image.bitmap());
if (image_bytes) {
- UserImage result(image, *image_bytes);
- result.MarkAsSafe();
+ // TODO(crbug.com/593251): Remove the data copy via |image_bytes|.
+ scoped_ptr<UserImage> result(new UserImage(image, *image_bytes));
+ result->MarkAsSafe();
return result;
}
- return UserImage(image);
+ return make_scoped_ptr(new UserImage(image));
}
UserImage::UserImage()
« no previous file with comments | « components/user_manager/user_image/user_image.h ('k') | components/wallpaper/wallpaper_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698