Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
index e83f13ccda622ee7123fd7bee10e0896183d796f..96fb299148d90a943fd31e80ae4ab887c2021449 100644
--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
@@ -827,7 +827,7 @@ void WallpaperManager::RemovePendingWallpaperFromList(
void WallpaperManager::SetPolicyControlledWallpaper(
const AccountId& account_id,
- const user_manager::UserImage& user_image) {
+ scoped_ptr<user_manager::UserImage> user_image) {
const user_manager::User* user =
user_manager::UserManager::Get()->FindUser(account_id);
if (!user) {
@@ -841,12 +841,12 @@ void WallpaperManager::SetPolicyControlledWallpaper(
cryptohome::AsyncMethodCaller::GetInstance()->AsyncGetSanitizedUsername(
GetUnhashedSourceForWallpaperFilesId(*user),
base::Bind(&WallpaperManager::SetCustomWallpaperOnSanitizedUsername,
- weak_factory_.GetWeakPtr(), account_id, user_image.image(),
+ weak_factory_.GetWeakPtr(), account_id, user_image->image(),
true /* update wallpaper */));
} else {
SetCustomWallpaper(account_id, wallpaper_files_id, "policy-controlled.jpeg",
wallpaper::WALLPAPER_LAYOUT_CENTER_CROPPED,
- user_manager::User::POLICY, user_image.image(),
+ user_manager::User::POLICY, user_image->image(),
true /* update wallpaper */);
}
}
@@ -947,13 +947,13 @@ void WallpaperManager::OnWallpaperDecoded(
wallpaper::WallpaperLayout layout,
bool update_wallpaper,
MovableOnDestroyCallbackHolder on_finish,
- const user_manager::UserImage& user_image) {
+ scoped_ptr<user_manager::UserImage> user_image) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
TRACE_EVENT_ASYNC_END0("ui", "LoadAndDecodeWallpaper", this);
// If decoded wallpaper is empty, we have probably failed to decode the file.
// Use default wallpaper in this case.
- if (user_image.image().isNull()) {
+ if (user_image->image().isNull()) {
// Updates user pref to default wallpaper.
WallpaperInfo info = {"",
wallpaper::WALLPAPER_LAYOUT_CENTER_CROPPED,
@@ -967,12 +967,12 @@ void WallpaperManager::OnWallpaperDecoded(
}
// Update the image, but keep the path which was set earlier.
- wallpaper_cache_[account_id].second = user_image.image();
+ wallpaper_cache_[account_id].second = user_image->image();
if (update_wallpaper) {
ash::Shell::GetInstance()
->desktop_background_controller()
- ->SetWallpaperImage(user_image.image(), layout);
+ ->SetWallpaperImage(user_image->image(), layout);
}
}
@@ -1075,10 +1075,10 @@ void WallpaperManager::OnDefaultWallpaperDecoded(
const wallpaper::WallpaperLayout layout,
scoped_ptr<user_manager::UserImage>* result_out,
MovableOnDestroyCallbackHolder on_finish,
- const user_manager::UserImage& user_image) {
- result_out->reset(new user_manager::UserImage(user_image));
+ scoped_ptr<user_manager::UserImage> user_image) {
+ *result_out = std::move(user_image);
ash::Shell::GetInstance()->desktop_background_controller()->SetWallpaperImage(
- user_image.image(), layout);
+ (*result_out)->image(), layout);
}
void WallpaperManager::StartLoadAndSetDefaultWallpaper(
« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h ('k') | chrome/browser/ui/webui/chromeos/image_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698