Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_loader.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: just rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/avatar/user_image_loader.cc
diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_loader.cc b/chrome/browser/chromeos/login/users/avatar/user_image_loader.cc
index d8fa49df6c6f86008c5a8c132ce6dbd458ab5791..d14dc879d69b47030b2c87402d2e992478123480 100644
--- a/chrome/browser/chromeos/login/users/avatar/user_image_loader.cc
+++ b/chrome/browser/chromeos/login/users/avatar/user_image_loader.cc
@@ -160,17 +160,18 @@ void UserImageRequest::OnImageFinalized(
gfx::ImageSkia final_image_skia =
gfx::ImageSkia::CreateFrom1xBitmap(final_image);
final_image_skia.MakeThreadSafe();
- user_manager::UserImage user_image(final_image_skia, image_bytes);
- user_image.set_file_path(image_info_.file_path);
+ scoped_ptr<user_manager::UserImage> user_image(
+ new user_manager::UserImage(final_image_skia, image_bytes));
+ user_image->set_file_path(image_info_.file_path);
if (image_info_.image_codec == ImageDecoder::ROBUST_JPEG_CODEC ||
image_bytes_regenerated)
- user_image.MarkAsSafe();
- image_info_.loaded_cb.Run(user_image);
+ user_image->MarkAsSafe();
+ image_info_.loaded_cb.Run(std::move(user_image));
delete this;
}
void UserImageRequest::OnDecodeImageFailed() {
- image_info_.loaded_cb.Run(user_manager::UserImage());
+ image_info_.loaded_cb.Run(make_scoped_ptr(new user_manager::UserImage));
delete this;
}
@@ -183,7 +184,9 @@ void DecodeImage(
bool data_is_ready) {
if (!data_is_ready) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(image_info.loaded_cb, user_manager::UserImage()));
+ FROM_HERE,
+ base::Bind(image_info.loaded_cb,
+ base::Passed(make_scoped_ptr(new user_manager::UserImage))));
return;
}

Powered by Google App Engine
This is Rietveld 408576698