Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 1794323003: Make user_manager::UserImage non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
index 0ca91fd1b90d77857ae96d13c53395a3f3d9f46f..18c652e78be0a29a57b05d1e79678a75e57510e4 100644
--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
@@ -687,11 +687,10 @@ void ChromeUserManagerImpl::GuestUserLoggedIn() {
// mount point. Legacy (--login-profile) value will be used for now.
// http://crosbug.com/230859
active_user_->SetStubImage(
- user_manager::UserImage(
+ make_scoped_ptr(new user_manager::UserImage(
*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
- IDR_PROFILE_PICTURE_LOADING)),
- user_manager::User::USER_IMAGE_INVALID,
- false);
+ IDR_PROFILE_PICTURE_LOADING))),
+ user_manager::User::USER_IMAGE_INVALID, false);
// Initializes wallpaper after active_user_ is set.
WallpaperManager::Get()->SetUserWallpaperNow(login::GuestAccountId());
@@ -797,11 +796,10 @@ void ChromeUserManagerImpl::KioskAppLoggedIn(
active_user_ = user_manager::User::CreateKioskAppUser(kiosk_app_account_id);
active_user_->SetStubImage(
- user_manager::UserImage(
+ make_scoped_ptr(new user_manager::UserImage(
*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
- IDR_PROFILE_PICTURE_LOADING)),
- user_manager::User::USER_IMAGE_INVALID,
- false);
+ IDR_PROFILE_PICTURE_LOADING))),
+ user_manager::User::USER_IMAGE_INVALID, false);
WallpaperManager::Get()->SetUserWallpaperNow(kiosk_app_account_id);
@@ -842,11 +840,10 @@ void ChromeUserManagerImpl::DemoAccountLoggedIn() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
active_user_ = user_manager::User::CreateKioskAppUser(login::DemoAccountId());
active_user_->SetStubImage(
- user_manager::UserImage(
+ make_scoped_ptr(new user_manager::UserImage(
*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
- IDR_PROFILE_PICTURE_LOADING)),
- user_manager::User::USER_IMAGE_INVALID,
- false);
+ IDR_PROFILE_PICTURE_LOADING))),
+ user_manager::User::USER_IMAGE_INVALID, false);
WallpaperManager::Get()->SetUserWallpaperNow(login::DemoAccountId());
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

Powered by Google App Engine
This is Rietveld 408576698