Fixing +fround(x) in asm typer.

Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N

Committed: https://crrev.com/ace6f1364ac63e986c30a5f4becd1820f6d5394c
Cr-Commit-Position: refs/heads/master@{#34756}

[bradn, 2016-03-14 00:49:15]

Description was changed from

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[bradn, 2016-03-14 00:49:22]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[titzer, 2016-03-14 09:48:39]

lgtm

https://codereview.chromium.org/1794303002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1794303002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1388: assertEquals(1, m.func(-1));
Can you add a couple more input values, e.g. around min int? Here and below.

[bradn, 2016-03-14 17:07:31]

https://codereview.chromium.org/1794303002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1794303002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1388: assertEquals(1, m.func(-1));
On 2016/03/14 09:48:39, titzer wrote:
> Can you add a couple more input values, e.g. around min int? Here and below.

Done.

Actually, at this point I think I'm going to move all the stdlib stuff out into
a separate file and do something more generic for it.
This file is getting too big.
But I'll defer that to a separate change.

[bradn, 2016-03-14 17:07:37]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-03-14 17:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1794303002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-03-14 17:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1794303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1794303002/20001

[commit-bot: I haz the power, 2016-03-14 17:29:11]

Description was changed from

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2016-03-14 17:29:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-14 17:29:31]

Description was changed from

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fixing +fround(x) in asm typer.

The rules for handling foreign functions were interfering with handling
of standard functions (such as fround).

Adding more tests around abs()

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N

Committed: https://crrev.com/ace6f1364ac63e986c30a5f4becd1820f6d5394c
Cr-Commit-Position: refs/heads/master@{#34756}
==========

[commit-bot: I haz the power, 2016-03-14 17:29:32]

Patchset 2 (id:??) landed as
https://crrev.com/ace6f1364ac63e986c30a5f4becd1820f6d5394c
Cr-Commit-Position: refs/heads/master@{#34756}