base/trace_event/process_memory_dump_unittest.cc - Issue 1793943002: Use sysctlbyname() to get kernel page size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_dump_unittest.cc

Issue 1793943002: Use sysctlbyname() to get kernel page size. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed to GetSystemPageSize Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/process_memory_dump_unittest.cc

diff --git a/base/trace_event/process_memory_dump_unittest.cc b/base/trace_event/process_memory_dump_unittest.cc

index cf87c94b1aa0c8f94256add34ec6fa8cd8025a6b..e7fe960cb11c2724f2ebb4bd29c037c6fef1b70a 100644

--- a/base/trace_event/process_memory_dump_unittest.cc

+++ b/base/trace_event/process_memory_dump_unittest.cc

@@ -223,7 +223,7 @@ TEST(ProcessMemoryDumpTest, GlobalAllocatorDumpTest) {

#if defined(COUNT_RESIDENT_BYTES_SUPPORTED)

TEST(ProcessMemoryDumpTest, CountResidentBytes) {

- const size_t page_size = base::GetPageSize();

+ const size_t page_size = ProcessMemoryDump::GetSystemPageSize();

// Allocate few page of dirty memory and check if it is resident.

const size_t size1 = 5 * page_size;