Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: mojo/shell/runner/child/test_native_main.cc

Issue 1793793002: Remove ShellConnection::WaitForInitialize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/runner/child/test_native_main.cc
diff --git a/mojo/shell/runner/child/test_native_main.cc b/mojo/shell/runner/child/test_native_main.cc
index f8e4532ee3089e260009006eaa97b7341f089fc5..8d0e23577a692c6e146025dced415e2e374830d6 100644
--- a/mojo/shell/runner/child/test_native_main.cc
+++ b/mojo/shell/runner/child/test_native_main.cc
@@ -14,7 +14,6 @@
#include "build/build_config.h"
#include "mojo/edk/embedder/embedder.h"
#include "mojo/edk/embedder/process_delegate.h"
-#include "mojo/message_pump/message_pump_mojo.h"
#include "mojo/shell/public/cpp/shell_client.h"
#include "mojo/shell/public/cpp/shell_connection.h"
#include "mojo/shell/runner/child/runner_connection.h"
@@ -57,12 +56,10 @@ int TestNativeMain(mojo::ShellClient* shell_client) {
mojo::edk::InitIPCSupport(&process_delegate, io_thread.task_runner());
- mojom::ShellClientRequest request;
- scoped_ptr<mojo::shell::RunnerConnection> connection(
- mojo::shell::RunnerConnection::ConnectToRunner(
- &request, ScopedMessagePipeHandle()));
- base::MessageLoop loop(mojo::common::MessagePumpMojo::Create());
- mojo::ShellConnection impl(shell_client, std::move(request));
+ base::MessageLoop loop;
+ mojo::ShellConnection impl(shell_client);;
+ scoped_ptr<mojo::shell::RunnerConnection> connection =
+ mojo::shell::RunnerConnection::Create(&impl, nullptr);
loop.Run();
mojo::edk::ShutdownIPCSupport();

Powered by Google App Engine
This is Rietveld 408576698