Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1793753002: Reland of Fix mini_installer to handle VS 2015 component builds (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, gab, vmiura, stanisc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1791483004/ ) Reason for revert: Suspect this was not the cause of Win32 builds breaking, and I don't want developers hitting this mini_installer bug. If reverting again please provide more details and a link to the breaks. Original issue's description: > Revert of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1787883005/ ) > > Reason for revert: > Suspect this has caused Win32 builders to break. > > BUG=594322 > > Original issue's description: > > Fix mini_installer to handle VS 2015 component builds > > > > The mini_installer needs to unpack more CRT DLLs now that we are using > > VS 2015. This change supports that, while still being VS 2013 > > compatible. > > > > TBR=gab@chromium.org > > BUG=594294 > > > > Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4 > > Cr-Commit-Position: refs/heads/master@{#380833} > > TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594294 > > Committed: https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873 > Cr-Commit-Position: refs/heads/master@{#380838} TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,vmiura@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594322 Committed: https://crrev.com/6e59014501844be38d71617a7d218a242cc76574 Cr-Commit-Position: refs/heads/master@{#380876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/tools/build/win/create_installer_archive.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
brucedawson
Created Reland of Fix mini_installer to handle VS 2015 component builds
4 years, 9 months ago (2016-03-12 15:37:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793753002/1
4 years, 9 months ago (2016-03-12 15:39:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 15:39:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 15:41:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e59014501844be38d71617a7d218a242cc76574
Cr-Commit-Position: refs/heads/master@{#380876}

Powered by Google App Engine
This is Rietveld 408576698