Fix build issues in base/ for Android x64

base/i18n/rtl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/rtl.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 243 matching lines @@
 
   // Unlike Windows, Linux and OS X can correctly display RTL glyphs out of the
   // box so there is no issue with displaying zero-width bidi control characters
   // on any system.  Thus no need for the !IsRTL() check here.
   if (text->empty())
     return false;
 
   bool ui_direction_is_rtl = IsRTL();
 
   bool has_rtl_chars = StringContainsStrongRTLChars(*text);
+  const size_t pos = 0;
+  const size_t num = 1;
   if (!ui_direction_is_rtl && has_rtl_chars) {
     WrapStringWithRTLFormatting(text);
-    text->insert(0U, 1U, kLeftToRightMark);
+    text->insert(pos, num, kLeftToRightMark);

[rmcilroy, 2014/02/25 11:01:37]

Is this change really necessary?  This file is already being compiled on Linux
in x64 isn't it?

[rmcilroy, 2014/02/26 15:14:31]

Please just do a static_cast<size_t>(0) here (and for all below).

     text->push_back(kLeftToRightMark);
   } else if (ui_direction_is_rtl && has_rtl_chars) {
     WrapStringWithRTLFormatting(text);
-    text->insert(0U, 1U, kRightToLeftMark);
+    text->insert(pos, num, kRightToLeftMark);
     text->push_back(kRightToLeftMark);
   } else if (ui_direction_is_rtl) {
     WrapStringWithLTRFormatting(text);
-    text->insert(0U, 1U, kRightToLeftMark);
+    text->insert(pos, num, kRightToLeftMark);
     text->push_back(kRightToLeftMark);
   } else {
     return false;
   }
 
   return true;
 }
 
 bool UnadjustStringForLocaleDirection(string16* text) {
   if (text->empty())
@@ skipping 40 matching lines @@
   }
 
   return false;
 }
 
 void WrapStringWithLTRFormatting(string16* text) {
   if (text->empty())
     return;
 
   // Inserting an LRE (Left-To-Right Embedding) mark as the first character.
-  text->insert(0U, 1U, kLeftToRightEmbeddingMark);
+  text->insert(static_cast<size_t>(0), static_cast<size_t>(1),
+               kLeftToRightEmbeddingMark);
 
   // Inserting a PDF (Pop Directional Formatting) mark as the last character.
   text->push_back(kPopDirectionalFormatting);
 }
 
 void WrapStringWithRTLFormatting(string16* text) {
   if (text->empty())
     return;
 
   // Inserting an RLE (Right-To-Left Embedding) mark as the first character.
-  text->insert(0U, 1U, kRightToLeftEmbeddingMark);
+  text->insert(static_cast<size_t>(0), static_cast<size_t>(1),
+               kRightToLeftEmbeddingMark);
 
   // Inserting a PDF (Pop Directional Formatting) mark as the last character.
   text->push_back(kPopDirectionalFormatting);
 }
 
 void WrapPathWithLTRFormatting(const FilePath& path,
                                string16* rtl_safe_path) {
   // Wrap the overall path with LRE-PDF pair which essentialy marks the
   // string as a Left-To-Right string.
   // Inserting an LRE (Left-To-Right Embedding) mark as the first character.
@@ skipping 32 matching lines @@
       begin == kRightToLeftOverride)
     ++begin_index;
   size_t end_index = text.length() - 1;
   if (text[end_index] == kPopDirectionalFormatting)
     --end_index;
   return text.substr(begin_index, end_index - begin_index + 1);
 }
 
 }  // namespace i18n
 }  // namespace base