Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179363006: Remove unused NSS dependencies in mac certificate handling code. (Closed)

Created:
6 years, 10 months ago by haavardm
Modified:
6 years, 9 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unused NSS dependencies in mac certificate handling code. Needed to avoid compile error when compiling for mac with OpenSSL. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254455

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M net/cert/cert_verify_proc_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/x509_certificate_mac.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haavardm
Moved some mac cleanup changes from 173853014 and 179053005(wtc) into this CL.
6 years, 10 months ago (2014-02-26 16:32:44 UTC) #1
wtc
Patch set 1 LGTM. Thanks. You don't need to mention issue 179053005 in the CL's ...
6 years, 10 months ago (2014-02-26 17:57:00 UTC) #2
haavardm
The CQ bit was checked by haavardm@opera.com
6 years, 9 months ago (2014-03-03 08:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/179363006/20001
6 years, 9 months ago (2014-03-03 08:14:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 11:10:14 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-03 11:10:14 UTC) #6
haavardm
The CQ bit was checked by haavardm@opera.com
6 years, 9 months ago (2014-03-03 11:21:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/179363006/20001
6 years, 9 months ago (2014-03-03 11:21:44 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 11:22:16 UTC) #9
Message was sent while issue was closed. 
Change committed as 254455

Powered by Google App Engine
This is Rietveld 408576698