Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 179363005: Remove dependency on element in applying color properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 179363005: Remove dependency on element in applying color properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/animations/pseudo-element-animation-with-color-crash-expected.txt ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index 78a0245da7aecc7f128add31de82281a9876f239..228339d499c00c342ed8cd95a0e6508d942a33b1 100644

--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -264,7 +264,7 @@ namespace WebCore {

if (state.applyPropertyToRegularStyle())

{{ set_value(property) }}(state.document().textLinkColors().colorFromPrimitiveValue(primitiveValue, state.style()->color()));

if (state.applyPropertyToVisitedLinkStyle())

- state.style()->{{visited_link_setter}}(state.document().textLinkColors().colorFromPrimitiveValue(primitiveValue, state.style()->color(), state.element()->isLink() /* forVisitedLink */));

+ state.style()->{{visited_link_setter}}(state.document().textLinkColors().colorFromPrimitiveValue(primitiveValue, state.style()->color(), true));

}

{%- endmacro %}