Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1793583002: Handle drop cap letters (Closed)

Created:
4 years, 9 months ago by wychen
Modified:
4 years, 9 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle drop cap letters BUG=593128 R=mdjones@chromium.org Committed: ccefff915b7e34ef3fe2d8e1876aa17bc203be68

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M java/org/chromium/distiller/webdocument/ElementAction.java View 1 3 chunks +10 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/ContentExtractorTest.java View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wychen
PTAL
4 years, 9 months ago (2016-03-14 16:12:19 UTC) #3
mdjones
lgtm https://codereview.chromium.org/1793583002/diff/1/java/org/chromium/distiller/webdocument/ElementAction.java File java/org/chromium/distiller/webdocument/ElementAction.java (right): https://codereview.chromium.org/1793583002/diff/1/java/org/chromium/distiller/webdocument/ElementAction.java#newcode36 java/org/chromium/distiller/webdocument/ElementAction.java:36: case "block": Please add a comment outlining that ...
4 years, 9 months ago (2016-03-14 16:58:27 UTC) #4
wychen
https://codereview.chromium.org/1793583002/diff/1/java/org/chromium/distiller/webdocument/ElementAction.java File java/org/chromium/distiller/webdocument/ElementAction.java (right): https://codereview.chromium.org/1793583002/diff/1/java/org/chromium/distiller/webdocument/ElementAction.java#newcode36 java/org/chromium/distiller/webdocument/ElementAction.java:36: case "block": On 2016/03/14 16:58:27, mdjones wrote: > Please ...
4 years, 9 months ago (2016-03-15 20:47:59 UTC) #5
wychen
4 years, 9 months ago (2016-03-15 20:49:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
ccefff915b7e34ef3fe2d8e1876aa17bc203be68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698