Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 179293007: Remove deprecated focusedNode APIs (Closed)

Created:
6 years, 9 months ago by maheshkk
Modified:
6 years, 9 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove deprecated focusedNode APIs Remove WebDocument::focusedNode and WebView::clearFocusedNode APIs as they are deprecated and not used anymore. BUG=258763 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/web/WebDocument.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebDocument.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
maheshkk
Last usage in Chromium for these APIs are removed here https://codereview.chromium.org/184933002/ Please take a look.
6 years, 9 months ago (2014-03-06 16:37:37 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-06 18:47:49 UTC) #2
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-06 18:57:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/179293007/1
6 years, 9 months ago (2014-03-06 19:03:46 UTC) #4
maheshkk
6 years, 9 months ago (2014-03-06 19:15:03 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 19:34:17 UTC) #6
Message was sent while issue was closed.
Change committed as 168669

Powered by Google App Engine
This is Rietveld 408576698