Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1792823002:
Add recipe roll tryjob to depot_tools CQ as experimental. (Closed)
|
Created:
4 years, 9 months ago by estaab Modified:
4 years, 7 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionAdd recipe roll tryjob to depot_tools CQ as experimental.
Depends on http://crrev.com/1787173003.
BUG=594265
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300365
Patch Set 1 #
Messages
Total messages: 21 (7 generated)
martiniss@chromium.org changed reviewers: + martiniss@chromium.org
lgtm
not lgtm We can't run this right now; it could expose internal recipe names, since the recipe roller tries to run internal recipes at the same time, which can expose recipe names, and potentially internal keywords.
The CQ bit was checked by martiniss@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792823002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
martiniss@chromium.org changed reviewers: + phajdan.jr@chromium.org, sergiyb@chromium.org
PTAL
Hm, what changed between Stephen's concerns and the later stamps? The concerns sound valid.
On 2016/04/06 at 20:13:21, phajdan.jr wrote: > Hm, what changed between Stephen's concerns and the later stamps? > > The concerns sound valid. That tryjob only runs on external projects; see https://groups.google.com/a/google.com/d/msg/chrome-infra/dtn99SKsEcw/xyXtvUD... and https://build.chromium.org/p/tryserver.infra/builders/Recipe%20Roll%20Downstr... for an example of one. It doesn't touch internal projects.
This should be good to go now; only external projects are run on the external trybot.
martiniss@chromium.org changed reviewers: + iannucci@chromium.org
Can we get this landed?
On 2016/04/29 at 17:30:48, martiniss wrote: > Can we get this landed? It's blocked on owners lgtm. phajdan, can you approve?
rs lgtm
The CQ bit was checked by martiniss@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792823002/1
Message was sent while issue was closed.
Description was changed from ========== Add recipe roll tryjob to depot_tools CQ as experimental. Depends on http://crrev.com/1787173003. BUG=594265 ========== to ========== Add recipe roll tryjob to depot_tools CQ as experimental. Depends on http://crrev.com/1787173003. BUG=594265 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300365 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300365 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
