Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks.

Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks. (patchset #15 id:270001 of https://codereview.chromium.org/1676683002/ )

Reason for revert:
Regressed linux sizes (iostream maybe?)

https://build.chromium.org/p/chromium/builders/Linux/builds/72899/steps/sizes/logs/stdio

Original issue's description:
> [Courgette] Clean up Disassembler; fix ELF Memory leaks.
>
> Cleaning up code surrounding Disassembler:
> - Extract AddressTranslator interface to be used across subclasses.
> - Use FileOffset = size_t by context.
> - Detailed comments & TODOs in DisassemblerElf32ARM.
> - Fix DisassemblerElf32ARM memory leaks.
> - Lots of superficial stylistic changes.
>
> Except for AddressTranslator routines and unit tests, shying away
> from control flow and logic changes.
>
> BUG=579206
>
> Committed: https://crrev.com/58b822d441f5c982e879e536fa3c1cbac8fd339a
> Cr-Commit-Position: refs/heads/master@{#380881}

TBR=grt@chromium.org,wfh@chromium.org,chrisha@chromium.org,andrewhayden@chromium.org,huangs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579206
Committed: https://crrev.com/4a95ca5a4bab60f9f54325036516b640d263e2ec
Cr-Commit-Position: refs/heads/master@{#380885}

[scottmg, 2016-03-12 23:54:19]

Created Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks.

[commit-bot: I haz the power, 2016-03-12 23:54:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1792603006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1792603006/1

[commit-bot: I haz the power, 2016-03-12 23:55:11]

Description was changed from

==========
Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks. (patchset #15
id:270001 of https://codereview.chromium.org/1676683002/ )

Reason for revert:
Regressed linux sizes (iostream maybe?)

https://build.chromium.org/p/chromium/builders/Linux/builds/72899/steps/sizes...

Original issue's description:
> [Courgette] Clean up Disassembler; fix ELF Memory leaks.
> 
> Cleaning up code surrounding Disassembler:
> - Extract AddressTranslator interface to be used across subclasses.
> - Use FileOffset = size_t by context.
> - Detailed comments & TODOs in DisassemblerElf32ARM.
> - Fix DisassemblerElf32ARM memory leaks.
> - Lots of superficial stylistic changes.
> 
> Except for AddressTranslator routines and unit tests, shying away
> from control flow and logic changes.
> 
> BUG=579206
> 
> Committed: https://crrev.com/58b822d441f5c982e879e536fa3c1cbac8fd339a
> Cr-Commit-Position: refs/heads/master@{#380881}

TBR=grt@chromium.org,wfh@chromium.org,chrisha@chromium.org,andrewhayden@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579206
==========

to

==========
Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks. (patchset #15
id:270001 of https://codereview.chromium.org/1676683002/ )

Reason for revert:
Regressed linux sizes (iostream maybe?)

https://build.chromium.org/p/chromium/builders/Linux/builds/72899/steps/sizes...

Original issue's description:
> [Courgette] Clean up Disassembler; fix ELF Memory leaks.
> 
> Cleaning up code surrounding Disassembler:
> - Extract AddressTranslator interface to be used across subclasses.
> - Use FileOffset = size_t by context.
> - Detailed comments & TODOs in DisassemblerElf32ARM.
> - Fix DisassemblerElf32ARM memory leaks.
> - Lots of superficial stylistic changes.
> 
> Except for AddressTranslator routines and unit tests, shying away
> from control flow and logic changes.
> 
> BUG=579206
> 
> Committed: https://crrev.com/58b822d441f5c982e879e536fa3c1cbac8fd339a
> Cr-Commit-Position: refs/heads/master@{#380881}

TBR=grt@chromium.org,wfh@chromium.org,chrisha@chromium.org,andrewhayden@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579206
==========

[commit-bot: I haz the power, 2016-03-12 23:55:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-12 23:56:57]

Description was changed from

==========
Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks. (patchset #15
id:270001 of https://codereview.chromium.org/1676683002/ )

Reason for revert:
Regressed linux sizes (iostream maybe?)

https://build.chromium.org/p/chromium/builders/Linux/builds/72899/steps/sizes...

Original issue's description:
> [Courgette] Clean up Disassembler; fix ELF Memory leaks.
> 
> Cleaning up code surrounding Disassembler:
> - Extract AddressTranslator interface to be used across subclasses.
> - Use FileOffset = size_t by context.
> - Detailed comments & TODOs in DisassemblerElf32ARM.
> - Fix DisassemblerElf32ARM memory leaks.
> - Lots of superficial stylistic changes.
> 
> Except for AddressTranslator routines and unit tests, shying away
> from control flow and logic changes.
> 
> BUG=579206
> 
> Committed: https://crrev.com/58b822d441f5c982e879e536fa3c1cbac8fd339a
> Cr-Commit-Position: refs/heads/master@{#380881}

TBR=grt@chromium.org,wfh@chromium.org,chrisha@chromium.org,andrewhayden@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579206
==========

to

==========
Revert of [Courgette] Clean up Disassembler; fix ELF Memory leaks. (patchset #15
id:270001 of https://codereview.chromium.org/1676683002/ )

Reason for revert:
Regressed linux sizes (iostream maybe?)

https://build.chromium.org/p/chromium/builders/Linux/builds/72899/steps/sizes...

Original issue's description:
> [Courgette] Clean up Disassembler; fix ELF Memory leaks.
>
> Cleaning up code surrounding Disassembler:
> - Extract AddressTranslator interface to be used across subclasses.
> - Use FileOffset = size_t by context.
> - Detailed comments & TODOs in DisassemblerElf32ARM.
> - Fix DisassemblerElf32ARM memory leaks.
> - Lots of superficial stylistic changes.
>
> Except for AddressTranslator routines and unit tests, shying away
> from control flow and logic changes.
>
> BUG=579206
>
> Committed: https://crrev.com/58b822d441f5c982e879e536fa3c1cbac8fd339a
> Cr-Commit-Position: refs/heads/master@{#380881}

TBR=grt@chromium.org,wfh@chromium.org,chrisha@chromium.org,andrewhayden@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579206

Committed: https://crrev.com/4a95ca5a4bab60f9f54325036516b640d263e2ec
Cr-Commit-Position: refs/heads/master@{#380885}
==========

[commit-bot: I haz the power, 2016-03-12 23:56:57]

Patchset 1 (id:??) landed as
https://crrev.com/4a95ca5a4bab60f9f54325036516b640d263e2ec
Cr-Commit-Position: refs/heads/master@{#380885}

[Will Harris, 2016-03-13 01:19:06]

two new static initializers it seems?

[huangs, 2016-03-13 16:38:49]

Yeah I included <iostream> in {disassembler_win32_x86.cc,
disassembler_win32_x64.cc} for "#if COURGETTE_HISTOGRAM_TARGETS" debug flow.
I didn't place he #include in an #if block for uniformity, but should do that.

Will run tools/linux/dump-static-initializers.py before and after change to
verify.