Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1792563002: Use SkImage rather than SkBitmap in webmediaplayer_android when drawing a video frame (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
qinmin
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri (slow - plz ping), posciak+watch_chromium.org, reed1
Base URL:
https://chromium.googlesource.com/chromium/src.git@baseline
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkImage rather than SkBitmap in webmediaplayer_android when drawing a video frame. Also, skip a copy that existed because Skia previously did not support GL_EXTERNAL_OES textures. It now does. This will allow Skia to drop support for texture-backed SkBitmaps in favor of texture-backed SkImages, a long standing goal. Committed: https://crrev.com/ee237af5f26904dc797b516627d3ae83b4444474 Cr-Commit-Position: refs/heads/master@{#403905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -60 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 4 chunks +39 lines, -57 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
bsalomon
4 years, 6 months ago (2016-06-23 19:38:15 UTC) #8
qinmin
lgtm
4 years, 6 months ago (2016-06-24 23:33:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1792563002/60001
4 years, 5 months ago (2016-06-27 13:15:51 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 13:47:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1792563002/60001
4 years, 5 months ago (2016-07-06 13:39:07 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 5 months ago (2016-07-06 14:26:59 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 14:27:01 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:30:25 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee237af5f26904dc797b516627d3ae83b4444474
Cr-Commit-Position: refs/heads/master@{#403905}

Powered by Google App Engine
This is Rietveld 408576698