Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: Tools/Scripts/run-bindings-tests

Issue 179253002: Fix resource leak (temporary files and directories) in run-bindings-tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/bindings/main.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/run-bindings-tests
diff --git a/Tools/Scripts/run-bindings-tests b/Tools/Scripts/run-bindings-tests
index bae4bf35caba0d17b78e93f598b07ae1968ee3c8..bdca8c664142dc17a6f632b5330ee280e9ac8657 100755
--- a/Tools/Scripts/run-bindings-tests
+++ b/Tools/Scripts/run-bindings-tests
@@ -29,7 +29,7 @@
# patch. This makes it easier to track and review changes in generated code.
import sys
-from webkitpy.common.system import executive
+from webkitpy.bindings.main import run_bindings_tests
def main(argv):
"""Runs Blink bindings IDL compiler on test IDL files and compares the
@@ -40,13 +40,11 @@ def main(argv):
--test-python: Run tests for Python compiler as well.
--verbose: Show output on success and logging messages (not just failure)
"""
- reset_results = "--reset-results" in argv
- test_python = "--test-python" in argv
- verbose = "--verbose" in argv
+ reset_results = '--reset-results' in argv
+ test_python = '--test-python' in argv
+ verbose = '--verbose' in argv
- from webkitpy.bindings.main import BindingsTests
-
- return BindingsTests(reset_results, test_python, verbose, executive.Executive()).main()
+ return run_bindings_tests(reset_results, test_python, verbose)
if __name__ == '__main__':
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/bindings/main.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698