Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1792473003: Revert "Initialize the font fallback when the direct write font" (Closed)

Created:
4 years, 9 months ago by Ilya Kulshin
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Initialize the font fallback when the direct write font" This is apparently causing crashes and hangs in Chromium. Possible cause of 593858 and possible cause of 594047. This reverts commit 042f859c19f71ca9feacddd1cb058ff59eed8963. Conflicts: src/ports/SkFontMgr_win_dw.cpp Committed: https://skia.googlesource.com/skia/+/351c0d24f1c093ca48d0d832b1d64df8644f87b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -33 lines) Patch
M src/ports/SkFontMgr_win_dw.cpp View 7 chunks +17 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Ilya Kulshin
ptal.
4 years, 9 months ago (2016-03-11 22:57:11 UTC) #4
bungeman-skia
I'm certainly ok with reverting to see if that's the issue. lgtm
4 years, 9 months ago (2016-03-11 23:10:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792473003/1
4 years, 9 months ago (2016-03-11 23:10:45 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 23:25:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792473003/1
4 years, 9 months ago (2016-03-11 23:25:54 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 23:26:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/351c0d24f1c093ca48d0d832b1d64df8644f87b7

Powered by Google App Engine
This is Rietveld 408576698