Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1792453004:
Disable newTabPagesShareProcess in ProcessesApiTest.Processes (Closed)
|
Created:
4 years, 9 months ago by afakhry Modified:
4 years, 9 months ago Reviewers:
ncarter (slow) CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable newTabPagesShareProcess in ProcessesApiTest.Processes
This test doesn't make sense in --site-per-process. Disable for now.
TBR=nick@chromium.org
BUG=594318
TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process
Committed: https://crrev.com/93d2ab1c0f3667e844390c30779b8ecb1d15bfed
Cr-Commit-Position: refs/heads/master@{#380887}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process ========== to ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. TBR=nick@chromium.org BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process ==========
afakhry@chromium.org changed reviewers: + nick@chromium.org
The CQ bit was checked by afakhry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792453004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by afakhry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792453004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by afakhry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792453004/1
Message was sent while issue was closed.
Description was changed from ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. TBR=nick@chromium.org BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process ========== to ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. TBR=nick@chromium.org BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. TBR=nick@chromium.org BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process ========== to ========== Disable newTabPagesShareProcess in ProcessesApiTest.Processes This test doesn't make sense in --site-per-process. Disable for now. TBR=nick@chromium.org BUG=594318 TEST=browser_tests --gtest_filter=ProcessesApiTest.Processes --site-per-process Committed: https://crrev.com/93d2ab1c0f3667e844390c30779b8ecb1d15bfed Cr-Commit-Position: refs/heads/master@{#380887} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/93d2ab1c0f3667e844390c30779b8ecb1d15bfed Cr-Commit-Position: refs/heads/master@{#380887} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
