Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 1792283007: Simplify/speedup collecting dictionary element keys (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify/speedup collecting dictionary element keys BUG= Committed: https://crrev.com/982efab91fee896077f8bd2317d7b2d1b6d49c41 Cr-Commit-Position: refs/heads/master@{#34779}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M src/elements.cc View 1 2 6 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-15 09:19:19 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-15 09:20:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792283007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792283007/20001
4 years, 9 months ago (2016-03-15 09:55:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/4357)
4 years, 9 months ago (2016-03-15 10:04:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792283007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792283007/40001
4 years, 9 months ago (2016-03-15 10:29:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 10:52:13 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 10:52:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/982efab91fee896077f8bd2317d7b2d1b6d49c41
Cr-Commit-Position: refs/heads/master@{#34779}

Powered by Google App Engine
This is Rietveld 408576698