Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: chrome/app_shim/app_shim_win.gypi

Issue 179223003: Adding app_shim executable on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved webstore.ico into win subdirectory. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app_shim/app_shim_win.gypi
diff --git a/chrome/app_shim/app_shim_win.gypi b/chrome/app_shim/app_shim_win.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..59391058c2e126e16c60c386debb1a5e9b5594e1
--- /dev/null
+++ b/chrome/app_shim/app_shim_win.gypi
@@ -0,0 +1,29 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'targets': [
+ # This is the app shim on Windows. It is a small binary that simply runs
+ # Chrome, passing along any command-line arguments.
+ {
+ 'target_name': 'win_app_shim',
+ 'type': 'executable',
+ 'include_dirs': [
+ '../..',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ ],
+ 'sources': [
+ 'app_shim_win.cc',
+ 'win_app_shim.rc',
+ ],
+ 'msvs_settings': {
jackhou1 2014/10/26 22:56:09 The other Windows exe's have a manifest file. I'm
robertshield 2014/10/27 17:30:50 You want one to avoid a bunch of shimming that ha
Matt Giuca 2014/10/30 06:39:05 OK, I haven't really looked into this. Since it do
robertshield 2014/10/31 16:58:30 API behaviour changes in different OS revisions an
Matt Giuca 2014/11/04 04:38:17 OK, I've added the manifest. Note: The way the bu
+ 'VCLinkerTool': {
+ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ },
+ },
+ },
+ ], # targets
+}

Powered by Google App Engine
This is Rietveld 408576698