Index: net/dns/mdns_client_unittest.cc |
diff --git a/net/dns/mdns_client_unittest.cc b/net/dns/mdns_client_unittest.cc |
index 832908944d1dd2c3210e9647c2a648ee6eaf3a03..488d518ee6925e7cb7a66b3c018f5236d6214694 100644 |
--- a/net/dns/mdns_client_unittest.cc |
+++ b/net/dns/mdns_client_unittest.cc |
@@ -301,6 +301,7 @@ class MDnsTest : public ::testing::Test { |
public: |
MDnsTest(); |
virtual ~MDnsTest(); |
+ virtual void SetUp() OVERRIDE; |
virtual void TearDown() OVERRIDE; |
void DeleteTransaction(); |
void DeleteBothListeners(); |
@@ -347,12 +348,11 @@ MDnsTest::MDnsTest() { |
MDnsTest::~MDnsTest() { |
} |
-void MDnsTest::TearDown() { |
- base::MessageLoop::current()->RunUntilIdle(); |
- |
- ASSERT_FALSE(test_client_->IsListeningForTests()); |
+void MDnsTest::SetUp() { |
+ test_client_->StartListening(); |
+} |
- base::MessageLoop::current()->AssertIdle(); |
+void MDnsTest::TearDown() { |
} |
void MDnsTest::SimulatePacketReceive(const char* packet, unsigned size) { |
@@ -408,8 +408,6 @@ TEST_F(MDnsTest, PassiveListeners) { |
ASSERT_TRUE(listener_printer->Start()); |
ASSERT_TRUE(listener_ptr->Start()); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
// Send the same packet twice to ensure no records are double-counted. |
EXPECT_CALL(delegate_privet, OnRecordUpdate(MDnsListener::RECORD_ADDED, _)) |
@@ -439,8 +437,6 @@ TEST_F(MDnsTest, PassiveListeners) { |
listener_privet.reset(); |
listener_printer.reset(); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(delegate_ptr, OnRecordUpdate(MDnsListener::RECORD_ADDED, _)) |
.Times(Exactly(2)); |
@@ -458,8 +454,6 @@ TEST_F(MDnsTest, PassiveListenersCacheCleanup) { |
ASSERT_TRUE(listener_privet->Start()); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(delegate_privet, OnRecordUpdate(MDnsListener::RECORD_ADDED, _)) |
.Times(Exactly(1)) |
.WillOnce(Invoke( |
@@ -494,8 +488,6 @@ TEST_F(MDnsTest, MalformedPacket) { |
ASSERT_TRUE(listener_printer->Start()); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(delegate_printer, OnRecordUpdate(MDnsListener::RECORD_ADDED, _)) |
.Times(Exactly(1)) |
.WillOnce(Invoke( |
@@ -532,8 +524,6 @@ TEST_F(MDnsTest, TransactionWithEmptyCache) { |
ASSERT_TRUE(transaction_privet->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
PtrRecordCopyContainer record_privet; |
EXPECT_CALL(*this, MockableRecordCallback(MDnsTransaction::RESULT_RECORD, _)) |
@@ -561,8 +551,6 @@ TEST_F(MDnsTest, TransactionCacheOnlyNoResult) { |
.Times(Exactly(1)); |
ASSERT_TRUE(transaction_privet->Start()); |
- |
- EXPECT_FALSE(test_client_->IsListeningForTests()); |
} |
TEST_F(MDnsTest, TransactionWithCache) { |
@@ -574,8 +562,6 @@ TEST_F(MDnsTest, TransactionWithCache) { |
ASSERT_TRUE(listener_irrelevant->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
SimulatePacketReceive(kSamplePacket1, sizeof(kSamplePacket1)); |
@@ -611,8 +597,6 @@ TEST_F(MDnsTest, AdditionalRecords) { |
ASSERT_TRUE(listener_privet->Start()); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(delegate_privet, OnRecordUpdate(MDnsListener::RECORD_ADDED, _)) |
.Times(Exactly(1)) |
.WillOnce(Invoke( |
@@ -639,8 +623,6 @@ TEST_F(MDnsTest, TransactionTimeout) { |
ASSERT_TRUE(transaction_privet->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(*this, |
MockableRecordCallback(MDnsTransaction::RESULT_NO_RESULTS, NULL)) |
.Times(Exactly(1)) |
@@ -662,8 +644,6 @@ TEST_F(MDnsTest, TransactionMultipleRecords) { |
ASSERT_TRUE(transaction_privet->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
PtrRecordCopyContainer record_privet; |
PtrRecordCopyContainer record_privet2; |
@@ -702,8 +682,6 @@ TEST_F(MDnsTest, TransactionReentrantDelete) { |
ASSERT_TRUE(transaction_->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
EXPECT_CALL(*this, MockableRecordCallback(MDnsTransaction::RESULT_NO_RESULTS, |
NULL)) |
.Times(Exactly(1)) |
@@ -722,8 +700,6 @@ TEST_F(MDnsTest, TransactionReentrantDeleteFromCache) { |
&delegate_irrelevant); |
ASSERT_TRUE(listener_irrelevant->Start()); |
- ASSERT_TRUE(test_client_->IsListeningForTests()); |
- |
SimulatePacketReceive(kSamplePacket1, sizeof(kSamplePacket1)); |
transaction_ = test_client_->CreateTransaction( |
@@ -772,8 +748,6 @@ TEST_F(MDnsTest, TransactionReentrantCacheLookupStart) { |
ASSERT_TRUE(transaction1->Start()); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
SimulatePacketReceive(kSamplePacket1, sizeof(kSamplePacket1)); |
} |
@@ -800,8 +774,6 @@ TEST_F(MDnsTest, ListenerReentrantDelete) { |
.Times(Exactly(1)) |
.WillOnce(InvokeWithoutArgs(this, &MDnsTest::DeleteBothListeners)); |
- EXPECT_TRUE(test_client_->IsListeningForTests()); |
- |
SimulatePacketReceive(kSamplePacket1, sizeof(kSamplePacket1)); |
EXPECT_EQ(NULL, listener1_.get()); |